Fix fallback not rendering #49576
Merged
Fix fallback not rendering #49576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
added
[Type] Bug
draganescu
added
the
Backport to Gutenberg RC
|
Flaky tests detected in 7ed8a81. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4606794317
|
MaggieCabrera
approved these changes
Apr 4, 2023
|
I just cherry-picked this PR to the release/15.5 branch to get it included in the next release: 3180818 |
ryanwelcher
pushed a commit
that referenced
this pull request
Apr 5, 2023
* remove useless check for empty fallback navigation * remove useless check for empty fallback navigation
ryanwelcher
removed
the
Backport to Gutenberg RC
|
Is there a way to cover this with a test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes a useless check for empty fallback meny blocks.
Why?
#48602 which reverted #47684 failed to remove the code at 8548085#diff-90cb5b64c95087ded3c7bb160e38189c8499b0f14f61beb884c887452449fa12R495
This code now prevents fallnack page list navigation from rendering on the front end.
How?
Remove the left over check for empty blocks. It only makes sense in the if branch before, where
$maybe_fallbackmay be empty because ofblock_core_navigation_filter_out_empty_blocks.Testing Instructions
wp-admin/edit.php?post_type=wp_navigation)